feat(alloy): forward rustls & native reqwest TLS configuration to Alloy's metacrate
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
rustls configuration to Alloy's metacraterustls & native reqwest TLS configuration to Alloy's metacrate
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
approved these changes
Jun 25, 2024
Evalir
approved these changes
Jun 25, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
… Alloy's metacrate (alloy-rs#969) * add reqwest feature flags to metacrate * enable reqwest when enabling sub-flag for consistency * remove redundant reqwest entry * avoid breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #965
In support of the suggested feature as people often express their preference for one over the other
Solution
Avoids introducing breaking changes, adds two new flags:
reqwest-rustls-tlsandreqwest-native-tlsIf a breaking change were permitted I would add the flag like this:
alloy/crates/alloy/Cargo.toml
Lines 67 to 103 in 7c1df0f
PR Checklist